Skip to content

chore: skip TLS verification for the Mattermost webhook - #456

Merged
KamilEmeleev merged 1 commit into
mainfrom
chore/MM-notifications
Aug 12, 2026
Merged

chore: skip TLS verification for the Mattermost webhook#456
KamilEmeleev merged 1 commit into
mainfrom
chore/MM-notifications

Conversation

@KamilEmeleev

@KamilEmeleev KamilEmeleev commented Aug 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated automated pull request and release notifications to improve delivery in environments with certificate validation issues.
    • No changes were made to the product experience or publicly available features.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates Mattermost notification steps in pull request and release workflows. Each step sets NODE_TLS_REJECT_UNAUTHORIZED to '0'.

Changes

Mattermost notification workflows

Layer / File(s) Summary
Mattermost notification TLS settings
.github/workflows/pr-notification.yml, .github/workflows/release.yml		 The pull request workflow sets NODE_TLS_REJECT_UNAUTHORIZED for main and development channel notifications. The release workflow sets the same variable for its notification step.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: disabling TLS verification for Mattermost webhook notifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/MM-notifications

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 97bf11c):

https://react-koobiq-next--prs-456-zov3jxpb.web.app

(expires Sun, 16 Aug 2026 12:56:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff

coderabbitai[bot]
coderabbitai Bot reviewed Aug 11, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pr-notification.yml:
- Around line 18-19: Remove the NODE_TLS_REJECT_UNAUTHORIZED: '0' environment
override from all Mattermost notification steps:
.github/workflows/pr-notification.yml lines 18-19 and 28-29, and
.github/workflows/release.yml lines 55-56. Preserve webhook notifications by
relying on a valid certificate chain or configuring a trusted private CA.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d3abc09-2d9b-4dcf-a91b-555f080b258b

📥 Commits

Reviewing files that changed from the base of the PR and between acd808c and 97bf11c.

📒 Files selected for processing (2)
  • .github/workflows/pr-notification.yml
  • .github/workflows/release.yml

Comment thread .github/workflows/pr-notification.yml
@KamilEmeleev
KamilEmeleev merged commit 3585b1f into main Aug 12, 2026
7 of 8 checks passed
@KamilEmeleev
KamilEmeleev deleted the chore/MM-notifications branch August 12, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KamilEmeleev